Skip to content

Update version of agents to be consistent with the latest releases#739

Closed
DMevada wants to merge 2 commits intocloudfoundry:masterfrom
DMevada:introscope-agent-updates
Closed

Update version of agents to be consistent with the latest releases#739
DMevada wants to merge 2 commits intocloudfoundry:masterfrom
DMevada:introscope-agent-updates

Conversation

@DMevada
Copy link
Copy Markdown
Contributor

@DMevada DMevada commented Jul 26, 2019

Before this commit, the current version of agents to be downloaded was 10.+. After this commit, the version will be 11.+.

@cfdreddbot
Copy link
Copy Markdown

cfdreddbot commented Jul 26, 2019

✅ Hey DMevada! The commit authors and yourself have already signed the CLA.

@DMevada
Copy link
Copy Markdown
Contributor Author

DMevada commented Aug 2, 2019

Hi @nebhale

Any updates on this PR?

-Dhruv

@nebhale nebhale self-requested a review August 20, 2019 16:46
@nebhale nebhale self-assigned this Aug 20, 2019
nebhale
nebhale suggested changes Aug 20, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@nebhale nebhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at https://ca.bintray.com/apm-agents/index.yml, there are no versions that would satisfy 11.+, this preventing the Buildpack from building. Please ensure that there is a version available that will satisfy the wildcard.

@nebhale nebhale added this to the v4.21 milestone Aug 20, 2019
@DMevada
Copy link
Copy Markdown
Contributor Author

DMevada commented Aug 22, 2019

Hi Ben,

I have added the latest version of our agent that supports 11.+ to our index file.

-Dhruv

@nebhale
Copy link
Copy Markdown
Contributor

nebhale commented Aug 22, 2019

Great. Can you please make it https:// as well? By policy we no longer include dependencies acquired via HTTP.

@DMevada
Copy link
Copy Markdown
Contributor Author

DMevada commented Aug 23, 2019

Hi Ben,

The config.yml file already has our repo location as https.
The repo itself is also https already as we cannot host our binaries without that.

-Dhruv

@nebhale
Copy link
Copy Markdown
Contributor

nebhale commented Aug 23, 2019

The binary in question (11.1.1_0) has an http:// URI:

➜  ~ curl https://ca.bintray.com/apm-agents/index.yml
---
11.1.1_0: http://ca.bintray.com/apm-agents/agent-default-11.1.1_0.tar
10.7.0_412: https://ca.bintray.com/apm-agents/agent-noinstaller-default-unix-10.6.0.179.tar
10.7.0_116: https://ca.bintray.com/apm-agents/IntroscopeAgentFiles-NoInstaller10.7.0_116default.unix.tar
10.7.0_70: https://ca.bintray.com/apm-agents/IntroscopeAgentFiles-NoInstaller10.7.0_70default.unix.tar
10.6.0_113: https://ca.bintray.com/apm-agents/IntroscopeAgentFiles-NoInstaller10.6.0_113default.unix.tar
10.6.0_0: https://ca.bintray.com/apm-agents/IntroscopeAgentFiles-NoInstaller10.6.0_0default.unix.tar
10.5.2_15: https://ca.bintray.com/apm-agents/IntroscopeAgentFiles-NoInstaller10.5.2_15default.unix.tar
10.5.1_6: https://ca.bintray.com/apm-agents/IntroscopeAgentFiles-NoInstaller10.5.1_6default.unix.tar
10.5.0_20: https://ca.bintray.com/apm-agents/IntroscopeAgentFiles-NoInstaller10.5.0_20default.unix.tar
10.3.0_15: https://ca.bintray.com/apm-agents/IntroscopeAgentFiles-NoInstaller10.3.0_15default.unix.tar
10.2.0_27: https://ca.bintray.com/apm-agents/IntroscopeAgentFiles-NoInstaller10.2.0_27default.unix.tar
10.1.0_15: https://ca.bintray.com/apm-agents/IntroscopeAgentFiles-NoInstaller10.1.0_15default.unix.tar
10.0.0_16: https://ca.bintray.com/apm-agents/IntroscopeAgentFiles-NoInstaller10.0.0_16default.unix.tar

@nebhale
Copy link
Copy Markdown
Contributor

nebhale commented Aug 26, 2019

@DMevada Can you please make this update soon? We're holding a Java Buildpack release for it now, but if takes much longer we'll have to kick it to the next release.

@DMevada
Copy link
Copy Markdown
Contributor Author

DMevada commented Aug 26, 2019 •
edited by nebhale
Loading

Hi @nebhale

I have moved on from CA and can no longer make any changes.
Please reach out to [REDACTED] for an update.

-Dhruv

@nebhale nebhale closed this in bee70cd Sep 4, 2019
ramonskie pushed a commit that referenced this pull request Dec 4, 2025
@DMevada @nebhale
Introscope Agent Upgrade
ffe66d6 
This change upgrades the version wildcard for Introscope to choose 11.x line
of releases.

[resolves #739]

Signed-off-by: Ben Hale <bhale@pivotal.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nebhale nebhale nebhale approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nebhale nebhale

Labels

framework

Projects

None yet

Milestone

v4.21

Development

Successfully merging this pull request may close these issues.

3 participants

@DMevada @cfdreddbot @nebhale